refactor: add new Pattern type that replaces IPatternMatcher<> to simplify API. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the API a lot simpler.
skwasjer
force-pushed
the
feature/refactor_pattern_matching
branch
from
5f72dca to
5cb39f8
Compare
|
|
This is some work towards #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely the
Pattern,RegexPatternandWildcardPatterntypes will become public, after we add some additional features, like additional overloads and a new builder to configure more fine-grained URI matchers (for parts of an URI) as mentioned in #110, #112 and documentation.For now, the types are internal though.